Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Branding #21

Merged
merged 4 commits into from
Jun 11, 2024
Merged

App Branding #21

merged 4 commits into from
Jun 11, 2024

Conversation

erdemyerebasmaz
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz commented Jun 11, 2024

Run CI

This PR addresses

Various assets are updated to give Liquid app it's own identity.

Changelist:

  • Updated App logo
    • and it's color on App Bar(Light Theme only)
  • Update Drawer footer image
  • Applied theme changes to splash screen on Android
  • Apply Breez theme on system navigation bar

This was linked to issues Jun 11, 2024
Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an inconsistency between the base and round/foreground images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would argue this is not going to be clearly visible on a device. Maybe just the B💧 is enough

@erdemyerebasmaz
Copy link
Collaborator Author

There seems to be an inconsistency between the base and round/foreground images.

Round icon is used for app icon on launcher, foreground image is used on splash screen whenever possible.

@erdemyerebasmaz
Copy link
Collaborator Author

erdemyerebasmaz commented Jun 11, 2024

@dangeross I've simplified resources, removed any obsolete or unnecessary ones, splash & launcher values are separated properly with no overlaps.

@erdemyerebasmaz erdemyerebasmaz force-pushed the app-branding branch 4 times, most recently from 31b87e5 to 67b880d Compare June 11, 2024 11:00
* Update Android launcher icons & splash theme
* Update App Icon color
@erdemyerebasmaz erdemyerebasmaz merged commit e87b256 into main Jun 11, 2024
1 check failed
@erdemyerebasmaz erdemyerebasmaz deleted the app-branding branch June 11, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Branding Update drawer footer image Update app logo
2 participants